Remove broken health checks for now #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
reviewed
Dec 2, 2025
| return false | ||
| } | ||
| } | ||
| // TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check |
Collaborator
There was a problem hiding this comment.
can we not check-in commented code?
Contributor
Author
There was a problem hiding this comment.
Sure, dropped the code
hehaifengcn
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The health checks enabled recently are too aggressive for what we want them to do. Keep the main branch available while we re-approach appropriate health checks.
Why?
The original health checks were trying to mark hosts healthy based on the availability of additional capacity on the inbound
or outbound connection. This is in general how we want routing to work when a remote host establishes an inbound mux and when a local host tries to get an outbound connection, but communicating that nuance to GCP/AWS load balancing hasn't been working out, resulting in host brownouts. Just disable the connectivity check for now.